Make several TableOpsImpl methods atomic #5540
Conversation
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public void clearSamplerConfiguration(String tableName) | ||
| throws AccumuloException, TableNotFoundException, AccumuloSecurityException { | ||
| throws AccumuloException, AccumuloSecurityException { |
There was a problem hiding this comment.
Why would this no longer throw TableNotFoundException? That seems odd.
There was a problem hiding this comment.
Nothing in this method throws TableNotFoundException anymore I guess. In the old code, clearSamplerOptions() threw it when it called getProperties() but all of that has been replaced with the modifyProperties() block which does not throw TableNotFoundException.
There was a problem hiding this comment.
I would expect modifyProperties to throw TableNotFoundException. At least, some error should happen if the table doesn't exist... I'm not sure what error that is. But, I think this PR should wait until we figure that out, because this changes the behavior, and we shouldn't change the API behavior for the case when the table doesn't exist.
Fixes #5494
This PR replaces places were multiple calls to set or remove properties were being done with a single modify properties block to make things atomic. The affected methods are: